Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
기존 elasticSearch를 사용했던 검색어 자동완성 기능을 Redis를 사용하도록 수정하였습니다.
어떤 부분에 리뷰어가 집중해야 하는지
로컬에서는 테스트 잘되는데 서버에 올리고도 redis가 잘돌아가는 테스트해보아야할것같습니다.
현재는 score를 0으로 설정하고 증가시키고 있진않은데 클라에게 검색어 자동완성기능을 사용하여 검색한 장소를 받는 api 사용가능한지 여부확인후 추가로 수정하겠습니다.
개발하면서 어떤 점이 궁금했는지
📸 결과물 스크린샷
🛠️ 테스트
🚀 API Endpoint